From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v4 01/15] net/avf/base: add base code for avf PMD Date: Mon, 8 Jan 2018 07:27:38 -0800 Message-ID: <20180108072738.6250adfd@xeon-e3> References: <1511505206-97333-1-git-send-email-jingjing.wu@intel.com> <1515140505-38655-1-git-send-email-wenzhuo.lu@intel.com> <1515140505-38655-2-git-send-email-wenzhuo.lu@intel.com> <20180105122552.70da9a37@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B70A8E8@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Wu, Jingjing" To: "Lu, Wenzhuo" Return-path: Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53]) by dpdk.org (Postfix) with ESMTP id 317ED1B014 for ; Mon, 8 Jan 2018 16:27:41 +0100 (CET) Received: by mail-pg0-f53.google.com with SMTP id q12so5729929pgt.7 for ; Mon, 08 Jan 2018 07:27:41 -0800 (PST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70A8E8@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 8 Jan 2018 01:06:36 +0000 "Lu, Wenzhuo" wrote: > > This function is way to big to be an inline. > Thanks for your comments. Let me explain. This is the base code, like what's in ixgbe, i40e ... We have to let it be so it's much easier for us to update it the next time. That's why the code style is a little different. And also some checkpatch problem not handled. > We have had some discussion about the copyright license here and internally. But unfortunately we don't achieve a conclusion internally so we have to keep the long license now and may change it later. If you have to have base code then put it in a subdirectory base/ that way reviewers and maintainers can separate DPDK part from ugly stuff.