From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 03/15] virtio: use eth_linkstatus_set
Date: Mon, 8 Jan 2018 09:03:38 -0800
Message-ID: <20180108090338.796c7796@xeon-e3>
References: <20180106010656.9167-1-stephen@networkplumber.org>
 <20180106010656.9167-4-stephen@networkplumber.org>
 <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Tiwei Bie <tiwei.bie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66])
 by dpdk.org (Postfix) with ESMTP id 141A1199B5
 for <dev@dpdk.org>; Mon,  8 Jan 2018 18:03:41 +0100 (CET)
Received: by mail-pg0-f66.google.com with SMTP id i196so5929459pgd.0
 for <dev@dpdk.org>; Mon, 08 Jan 2018 09:03:41 -0800 (PST)
In-Reply-To: <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, 6 Jan 2018 11:10:08 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:

> Hi Stephen,
> 
> On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote:
> > Use the new comon code in ethdev to handle link status update.  
> 
> Typo: comon -> common
> 
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> [...]
> >  static void
> >  virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> >  {
> > @@ -1913,8 +1872,13 @@ static void
> >  virtio_dev_stop(struct rte_eth_dev *dev)
> >  {
> >  	struct virtio_hw *hw = dev->data->dev_private;
> > -	struct rte_eth_link link;
> >  	struct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf;
> > +	struct rte_eth_link link = {
> > +		.link_speed = SPEED_10G,  
> 
> SPEED_10G has been removed on dpdk-next-virtio:

Patch was intended for current release so not looking at -next