From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v3 05/11] event/octeontx: update octeontx
 eventdev selftest ops
Date: Mon, 8 Jan 2018 15:39:07 +0530
Message-ID: <20180108100906.GD24213@jerin>
References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com>
 <20171225191738.17151-1-pbhagavatula@caviumnetworks.com>
 <20171225191738.17151-5-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: harry.van.haaren@intel.com, gage.eads@intel.com, liang.j.ma@intel.com,
 dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0073.outbound.protection.outlook.com [104.47.32.73])
 by dpdk.org (Postfix) with ESMTP id 412321B040
 for <dev@dpdk.org>; Mon,  8 Jan 2018 11:09:29 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20171225191738.17151-5-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 26 Dec 2017 00:47:32 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
>  gage.eads@intel.com, liang.j.ma@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v3 05/11] event/octeontx: update octeontx
>  eventdev selftest ops
> X-Mailer: git-send-email 2.14.1
> 
> Update octeontx eventdev ops to invoke selftest when application
> invokes `rte_event_dev_selftest`.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  drivers/event/octeontx/Makefile      | 3 ++-
>  drivers/event/octeontx/ssovf_evdev.c | 2 ++
>  drivers/event/octeontx/ssovf_evdev.h | 4 ++++
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/event/octeontx/Makefile b/drivers/event/octeontx/Makefile
> index fdf1b7385..1ad638574 100644
> --- a/drivers/event/octeontx/Makefile
> +++ b/drivers/event/octeontx/Makefile
> @@ -42,7 +42,7 @@ CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx/
>  CFLAGS += -I$(RTE_SDK)/drivers/net/octeontx/
>  
>  LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx
> -LDLIBS += -lrte_bus_pci
> +LDLIBS += -lrte_bus_pci -lrte_mempool -lrte_mbuf
>  LDLIBS += -lrte_bus_vdev
>  
>  EXPORT_MAP := rte_pmd_octeontx_ssovf_version.map
> @@ -54,6 +54,7 @@ LIBABIVER := 1
>  #
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += ssovf_worker.c
>  SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += ssovf_evdev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += octeontx_evdev_selftest.c

Every other file in this directory starts with ssovf_*. IMO, better to
change to ssovf_evdev_selftest.c

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>