From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v3 02/11] eventdev: add API to perform self
 test
Date: Mon, 8 Jan 2018 16:04:14 +0530
Message-ID: <20180108103413.qv3qqccu3pxjcfne@Pavan-LT>
References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com>
 <20171225191738.17151-1-pbhagavatula@caviumnetworks.com>
 <20171225191738.17151-2-pbhagavatula@caviumnetworks.com>
 <20180108095621.GB24213@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 harry.van.haaren@intel.com, gage.eads@intel.com, liang.j.ma@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0063.outbound.protection.outlook.com [104.47.34.63])
 by dpdk.org (Postfix) with ESMTP id 503631B16A
 for <dev@dpdk.org>; Mon,  8 Jan 2018 11:34:35 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180108095621.GB24213@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jerin,

Thanks for the review, will send out a v4 addressing the comments.

On Mon, Jan 08, 2018 at 03:26:23PM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Tue, 26 Dec 2017 00:47:29 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
> >  gage.eads@intel.com, liang.j.ma@intel.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v3 02/11] eventdev: add API to perform self test
> > X-Mailer: git-send-email 2.14.1
> >
> > Add API to perform self test on the underlying event device driver.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> > ---
> > + * Start eventdev selftest.
> > + *
> > + * @return
> > + *   Return 0 on success.
> > + */
> > +typedef int (*eventdev_selftest)
> > +			(void);
>
> I think, The (void) need not to be in a separate line.
>
> With above change:
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>