From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 6/6] app/testpmd: adjust ethdev port
	ownership
Date: Mon, 8 Jan 2018 12:39:46 +0100
Message-ID: <20180108113946.hcgxvulamjsiepre@bidouze.vm.6wind.com>
References: <1511870281-15282-1-git-send-email-matan@mellanox.com>
 <1515318351-4756-1-git-send-email-matan@mellanox.com>
 <1515318351-4756-7-git-send-email-matan@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org,
 Neil Horman <nhorman@tuxdriver.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
To: Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id E31C91B010
 for <dev@dpdk.org>; Mon,  8 Jan 2018 12:39:59 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id 9so13487307wme.4
 for <dev@dpdk.org>; Mon, 08 Jan 2018 03:39:59 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1515318351-4756-7-git-send-email-matan@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Matan,

On Sun, Jan 07, 2018 at 09:45:51AM +0000, Matan Azrad wrote:
> Testpmd should not use ethdev ports which are managed by other DPDK
> entities.
> 
> Set Testpmd ownership to each port which is not used by other entity and
> prevent any usage of ethdev ports which are not owned by Testpmd.
> 

This patch should not be necessary.

Ideally, your API evolution should not impact the default case. As such,
the default iterator RTE_ETH_FOREACH_DEV should still be used in
testpmd.

RTE_ETH_FOREACH_DEV should call RTE_ETH_FOREACH_DEV_OWNED_BY, with the
default owner (meaning that it would thus iterate on the
application-owned set of device).

This new API should avoid breaking the current code as much as possible.

-- 
Gaëtan Rivet
6WIND