From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajit Khaparde Subject: [PATCH 02/13] net/bnxt: fix double increment of idx during Tx ring alloc Date: Mon, 8 Jan 2018 12:24:26 -0800 Message-ID: <20180108202437.56305-3-ajit.khaparde@broadcom.com> References: <20180108202437.56305-1-ajit.khaparde@broadcom.com> Cc: ferruh.yigit@intel.com To: dev@dpdk.org Return-path: Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 10BC21B1A7 for ; Mon, 8 Jan 2018 21:24:42 +0100 (CET) In-Reply-To: <20180108202437.56305-1-ajit.khaparde@broadcom.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We are incrementing idx twice while allocating Tx rings. Since this is passed to the firmware, it may cause unexpected behavior. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ring.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index 0fa2f0c0d..e0ca0e7f3 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -362,9 +362,6 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp) struct bnxt_ring *ring = txr->tx_ring_struct; unsigned int idx = i + 1 + bp->rx_cp_nr_rings; - /* Account for AGG Rings. AGG ring cnt = Rx Cmpl ring cnt */ - idx += bp->rx_cp_nr_rings; - /* Tx cmpl */ rc = bnxt_hwrm_ring_alloc(bp, cp_ring, HWRM_RING_ALLOC_INPUT_RING_TYPE_L2_CMPL, -- 2.14.3 (Apple Git-98)