From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [PATCH v7 3/3] net/virtio: support GUEST ANNOUNCE
Date: Tue, 9 Jan 2018 21:36:17 +0800
Message-ID: <20180109133617.GN29540@yliu-mob>
References: <20180107120513.142196-3-xiao.w.wang@intel.com>
 <febade73-de32-dcd6-2f52-356689dff3a3@redhat.com>
 <B7F2E978279D1D49A3034B7786DACF406F80A5C2@SHSMSX101.ccr.corp.intel.com>
 <2111831.jDyPzsQBf4@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Wang, Xiao W" <xiao.w.wang@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 "Bie, Tiwei" <tiwei.bie@intel.com>, dev@dpdk.org,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9697C1B1C5
 for <dev@dpdk.org>; Tue,  9 Jan 2018 14:36:23 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <2111831.jDyPzsQBf4@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 09, 2018 at 12:41:53PM +0100, Thomas Monjalon wrote:
> > > Do you think it could make sense to have this function in a lib, as
> > > vhost user lib does exactly the same?
> > > 
> > > I don't know if it could be useful to others than vhost/virtio though.
> > 
> > Hi Thomas,
> > 
> > Do you think it's worth adding a new helper for ARP in lib/librte_net/?
> > Currently we just need a helper to build RARP packet (the above make_rarp_packet)
> 
> Yes, good idea

+1

	--yliu