From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] event/sw: remove stale IQ references when
	reconfigured
Date: Thu, 11 Jan 2018 00:30:07 +0530
Message-ID: <20180110190006.GA32568@jerin>
References: <1515514775-10859-1-git-send-email-gage.eads@intel.com>
 <20180110102615.42jh4hkprgombzki@Pavan-LT>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gage Eads <gage.eads@intel.com>, harry.van.haaren@intel.com,
 santosh.shukla@caviumnetworks.com, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46])
 by dpdk.org (Postfix) with ESMTP id 342FE1B24A
 for <dev@dpdk.org>; Wed, 10 Jan 2018 20:00:29 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180110102615.42jh4hkprgombzki@Pavan-LT>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 10 Jan 2018 15:56:16 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: Gage Eads <gage.eads@intel.com>, jerin.jacob@caviumnetworks.com,
>  harry.van.haaren@intel.com, santosh.shukla@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] event/sw: remove stale IQ references when reconfigured
> User-Agent: NeoMutt/20170609 (1.8.3)
> 
> On Tue, Jan 09, 2018 at 10:19:35AM -0600, Gage Eads wrote:
> > This commit fixes a bug in which, when the sw PMD is reconfigured, it would
> > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD
> > initializes all IQs at eventdev start time and releases all IQ chunk
> > pointers at eventdev stop time (which has the consequence that any events
> > in a queue when the eventdev is stopped will be lost). This approach should
> > be resilient to any reconfiguration done between the stop and start, such
> > as adding or removing queues.
> >
> > This commit also fixes two potential issues in iq_chunk.h. iq_init()
> > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets
> > iq->head to the appropriate next pointer.
> >
> > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs")
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> Sw eventdev works well alongside Rx adapter now.
> 
> Cheers,
> Pavan.
> 
> Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Applied to dpdk-next-eventdev/master. Thanks.