From mboxrd@z Thu Jan 1 00:00:00 1970 From: David C Harton Subject: [PATCH v2] net/i40e: fix VF reset stats crash Date: Thu, 11 Jan 2018 08:48:14 -0500 Message-ID: <20180111134814.1224-1-dharton@cisco.com> References: <20180111132337.14389-1-dharton@cisco.com> Cc: dev@dpdk.org, David C Harton , wei.zhao1@intel.com To: jingjing.wu@intel.com, beilei.xing@intel.com Return-path: Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id BA8F6A48F for ; Thu, 11 Jan 2018 14:48:17 +0100 (CET) In-Reply-To: <20180111132337.14389-1-dharton@cisco.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue by adding a pstats NULL check. Fixes: 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") Cc: wei.zhao1@intel.com Signed-off-by: David C Harton --- v2: * Fixed fixes line in commit message. drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index b96d77a..9c773fe 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -923,7 +923,8 @@ i40evf_dev_xstats_reset(struct rte_eth_dev *dev) i40evf_query_stats(dev, &pstats); /* set stats offset base on current values */ - vf->vsi.eth_stats_offset = *pstats; + if (pstats != NULL) + vf->vsi.eth_stats_offset = *pstats; } static int i40evf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, -- 2.10.3.dirty