From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH 1/4] drivers/mempool: add octeontx mempool
 driver to meson build
Date: Thu, 11 Jan 2018 19:43:46 +0530
Message-ID: <20180111141345.337ieawxy4w2sxgj@Pavan-LT>
References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com>
 <20180109174123.GD6508@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 harry.van.haaren@intel.com, jerin.jacob@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0055.outbound.protection.outlook.com [104.47.32.55])
 by dpdk.org (Postfix) with ESMTP id 47A567289
 for <dev@dpdk.org>; Thu, 11 Jan 2018 15:14:09 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180109174123.GD6508@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 09, 2018 at 05:41:23PM +0000, Bruce Richardson wrote:
> On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote:
> > Add octeontx hardware mempool driver to meson build.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> On the set as a whole, it looks good to me, just the few minor nits pointed
> out in other emails. Can you do a V2 with those fixed? Also, I notice
> that you are missing License tags on the new files created, those should
> probably be added too in V2.

At the time of sending the patchset we didnt have approval for SPDX licence
tags so, left them bare will update the tags in v2.

>
> Thanks,
> /Bruce

Thanks,
Pavan.