From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH 2/5] net/mrvl: fix hif objects allocation
Date: Mon, 15 Jan 2018 07:53:06 +0100
Message-ID: <20180115065306.GA17023@sh.semihalf.local>
References: <1515684943-32506-1-git-send-email-tdu@semihalf.com>
 <1515684943-32506-3-git-send-email-tdu@semihalf.com>
 <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, jck@semihalf.com,
 mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@arm.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com
 [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 86DEC25B3
 for <dev@dpdk.org>; Mon, 15 Jan 2018 07:53:09 +0100 (CET)
Received: by mail-lf0-f45.google.com with SMTP id w23so12009076lfd.11
 for <dev@dpdk.org>; Sun, 14 Jan 2018 22:53:09 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <7902c50d-59b2-2f9f-510b-a9ec2000e98d@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 12, 2018 at 07:13:22PM +0000, Ferruh Yigit wrote:
> On 1/11/2018 3:35 PM, Tomasz Duszynski wrote:
> > From: Natalie Samsonov <nsamsono@marvell.com>
>
> Commit title updated to [1] assuming hif is an abbreviation (btw, what is=
 hif?)

Thanks for fixing that. HIF stands for host-interface. You want to allocate
it per lcore so that couple of lcores can use MUSDK library simultaneously.

>
> [1]
> net/mrvl: fix HIF objects allocation
>
> >
> > 1. Add checking for non-EAL threads.
> >
> > 2. Create hif objects on first use since sometimes on probe not all
> >    lcores are initialized and can be added later.
> >    In this case the hif objects for later cores were not created and
> >    this caused system crash.
> >
> > Fixes: 0ddc9b8 ("net/mrvl: add net PMD skeleton")
>
> Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton")
> Cc: stable@dpdk.org
>
> >
> > Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
>
> <...>
>

--
- Tomasz Duszy=C5=84ski