From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v2 2/5] eal: add platform mempool ops name in internal config Date: Mon, 15 Jan 2018 17:54:46 +0530 Message-ID: <20180115122445.GB29114@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com To: Hemant Agrawal Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82]) by dpdk.org (Postfix) with ESMTP id 03B557CFC for ; Mon, 15 Jan 2018 13:25:06 +0100 (CET) Content-Disposition: inline In-Reply-To: <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Mon, 15 Jan 2018 11:41:11 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com, > santosh.shukla@caviumnetworks.com > Subject: [PATCH v2 2/5] eal: add platform mempool ops name in internal > config > X-Mailer: git-send-email 2.7.4 > > Signed-off-by: Hemant Agrawal > --- > lib/librte_eal/common/eal_common_options.c | 1 + > lib/librte_eal/common/eal_internal_cfg.h | 2 ++ > lib/librte_eal/rte_eal_version.map | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index b6d2762..1ed0ddb 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -219,6 +219,7 @@ eal_reset_internal_config(struct internal_config *internal_cfg) > internal_cfg->vmware_tsc_map = 0; > internal_cfg->create_uio_dev = 0; > internal_cfg->user_mbuf_pool_ops_name = NULL; > + internal_cfg->plat_mbuf_pool_ops_name = NULL; > } > > static int > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > index 1169fcc..12c5b8a 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -54,6 +54,8 @@ struct internal_config { > const char *hugepage_dir; /**< specific hugetlbfs directory to use */ > const char *user_mbuf_pool_ops_name; > /**< user defined mbuf pool ops name */ > + const char *plat_mbuf_pool_ops_name; > + /**< platform configured mbuf pool ops name */ > unsigned num_hugepage_sizes; /**< how many sizes on this system */ > struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; > }; > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 3fa1e13..909691f 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -203,6 +203,7 @@ DPDK_17.11 { > DPDK_18.02 { > global: > > + internal_config; I think, exposing the internal_config may not be a good idea. We may need "plat_mbuf_pool_ops_name" value for multi process case too. Considering the above points, How about adding it in struct rte_config and then expose too rte_eal_get_configuration() On the downside, it would be an ABI change. > rte_hypervisor_get; > rte_hypervisor_get_name; > > -- > 2.7.4 >