From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guo Subject: Re: [PATCH v4] app/testpmd: add option ring-bind-lcpu to bind Q with CPU Date: Tue, 16 Jan 2018 10:13:36 +0800 Message-ID: <20180116021336.GC2609@simonLocalRHEL7.x64> References: <1515571177-24040-1-git-send-email-wei.guo.simon@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B7109A8@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: "Lu, Wenzhuo" Return-path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 9798AA48D for ; Tue, 16 Jan 2018 03:13:39 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id j3so8907219pfh.8 for ; Mon, 15 Jan 2018 18:13:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7109A8@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wenzuo, On Mon, Jan 15, 2018 at 08:31:52AM +0000, Lu, Wenzhuo wrote: > Hi Simon, > > > > -----Original Message----- > > From: wei.guo.simon@gmail.com [mailto:wei.guo.simon@gmail.com] > > Sent: Wednesday, January 10, 2018 4:00 PM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org; Simon Guo > > Subject: [PATCH v4] app/testpmd: add option ring-bind-lcpu to bind Q with > > CPU > > > > From: Simon Guo > > > > Currently the rx/tx queue is allocated from the buffer pool on socket of: > > - port's socket if --port-numa-config specified > > - or ring-numa-config setting per port > > > > All the above will "bind" queue to single socket per port configuration. > > But it can actually archieve better performance if one port's queue can be > > spread across multiple NUMA nodes, and the rx/tx queue is allocated per > > lcpu socket. > > > > This patch adds a new option "--ring-bind-lcpu"(no parameter). With this, > > testpmd can utilize the PCI-e bus bandwidth on another NUMA nodes. > > > > When --port-numa-config or --ring-numa-config option is specified, this -- > > ring-bind-lcpu option will be suppressed. > > > > Test result: > > 64bytes package, running in PowerPC with Mellanox > > CX-4 card, single port(100G), with 8 cores, fw mode: > > - Without this patch: 52.5Mpps throughput > > - With this patch: 66Mpps throughput > > ~25% improvement > > > > Signed-off-by: Simon Guo > This patch is fine. But for the new parameter, please update this doc, run_app.rst. Thanks. ah...yes. I will rework on v5. Thanks, - Simon