From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH 3/3] app/testpmd: set preferred mempool as
 default pktpool
Date: Tue, 16 Jan 2018 13:50:33 +0530
Message-ID: <20180116082032.v3jnmsq5hbc7yt3l@Pavan-LT>
References: <20171213195538.14290-1-pbhagavatula@caviumnetworks.com>
 <20171213195538.14290-4-pbhagavatula@caviumnetworks.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B711113@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0060.outbound.protection.outlook.com [104.47.42.60])
 by dpdk.org (Postfix) with ESMTP id EF461A84E
 for <dev@dpdk.org>; Tue, 16 Jan 2018 09:20:54 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B711113@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Lu,

On Tue, Jan 16, 2018 at 06:06:50AM +0000, Lu, Wenzhuo wrote:
> Hi Pavan,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh
> > Sent: Thursday, December 14, 2017 3:56 AM
> > To: jerin.jacob@caviumnetworks.com; Wu, Jingjing <jingjing.wu@intel.com>;
> > Richardson, Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com;
> > Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net;
> > olivier.matz@6wind.com
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: set preferred mempool as
> > default pktpool
> >
> > Set the mempool preferred by the ethernet devices as default mbuf
> > mempool before creating the pktpool.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  app/test-pmd/testpmd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> > c3ab44849..bfea35613 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -533,6 +533,8 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned
> > nb_mbuf,
> >  		rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL);
> >  	} else {
> >  		/* wrapper to rte_mempool_create() */
> > +		RTE_LOG(INFO, USER1, "preferred mempool ops %s
> > selected\n",
> > +				rte_eth_dev_get_preferred_pool_name(1));
> This '1'  looks like hardcode. May I suggest to change it to 'true'?

This patchset will be superseeded by http://dpdk.org/dev/patchwork/patch/33716/
I will mark the same.

Thanks,
Pavan.