From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH 1/3] app/testpmd: Moved cmdline_flow to
 librte_cmdline
Date: Tue, 16 Jan 2018 09:39:58 +0100
Message-ID: <20180116083958.hk4rtxfoa2y3uydk@platinum>
References: <1515790887-64502-1-git-send-email-george.dit@gmail.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Georgios Katsikas <george.dit@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Adrien Mazarguil (adrien.mazarguil@6wind.com)" <adrien.mazarguil@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id E2FCC31FC
 for <dev@dpdk.org>; Tue, 16 Jan 2018 09:40:03 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Georgios,

On Mon, Jan 15, 2018 at 01:30:35AM +0000, Lu, Wenzhuo wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Georgios Katsikas
> > Sent: Saturday, January 13, 2018 5:01 AM
> > To: olivier.matz@6wind.com
> > Cc: dev@dpdk.org; Georgios Katsikas <george.dit@gmail.com>
> > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to
> > librte_cmdline
> > 
> > Signed-off-by: Georgios Katsikas <george.dit@gmail.com>
> Looks like a good idea to move this code to the lib.
> cc Adrien the author of this file, app/test-pmd/cmdline_flow.c.

If the command line parsing of rte_flow is something that has some
chances to be shared among multiple applications, I agree it makes sense
to move it in a library.

However, my opinion is that it would be better to have a specific
library for it, like librte_flow_cmdline, because I'm not sure that
people linking with librte_cmdline always want to pull the rte_flow
parsing code.