From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: [BUG] failsafe depending on return value from PMD
 link_update function.
Date: Tue, 16 Jan 2018 10:29:06 -0800
Message-ID: <20180116102906.0df665b6@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: gaetan.rivet@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51])
 by dpdk.org (Postfix) with ESMTP id D20A11B351
 for <dev@dpdk.org>; Tue, 16 Jan 2018 19:29:09 +0100 (CET)
Received: by mail-pg0-f51.google.com with SMTP id c194so9902926pga.12
 for <dev@dpdk.org>; Tue, 16 Jan 2018 10:29:09 -0800 (PST)
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

While doing link status refactoring, I noticed that the eth_dev_link_update function
return value is unused by common code (in rte_eth_dev_link_get); but is being expected
by failsafe driver.

The return values are not consistent across drivers, and link update function is only
valid if device is not using LSC.  Therefore, the failsafe PMD should not be calling
device internal functions directly and expecting a valid return value.