From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH v5 14/15] net/octeontx: use rte_eth_linkstatus_set Date: Tue, 16 Jan 2018 10:37:54 -0800 Message-ID: <20180116183755.24542-15-stephen@networkplumber.org> References: <20180116183755.24542-1-stephen@networkplumber.org> Cc: Stephen Hemminger To: dev@dpdk.org Return-path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 41FDA1B3CC for ; Tue, 16 Jan 2018 19:38:21 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id y27so3930085pgc.5 for ; Tue, 16 Jan 2018 10:38:21 -0800 (PST) In-Reply-To: <20180116183755.24542-1-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Common function matches this drivers usage. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 4f71f9def7e9..fd03d22646f4 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -463,20 +463,6 @@ octeontx_dev_promisc_disable(struct rte_eth_dev *dev) octeontx_port_promisc_set(nic, 0); } -static inline int -octeontx_atomic_write_link_status(struct rte_eth_dev *dev, - struct rte_eth_link *link) -{ - struct rte_eth_link *dst = &dev->data->dev_link; - struct rte_eth_link *src = link; - - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, - *(uint64_t *)src) == 0) - return -1; - - return 0; -} - static int octeontx_port_link_status(struct octeontx_nic *nic) { @@ -548,7 +534,8 @@ octeontx_dev_link_update(struct rte_eth_dev *dev, link.link_duplex = ETH_LINK_AUTONEG; link.link_autoneg = ETH_LINK_SPEED_AUTONEG; - return octeontx_atomic_write_link_status(dev, &link); + rte_eth_linkstatus_set(dev, &link); + return 0; } static int -- 2.15.1