From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [BUG] failsafe depending on return value from PMD
 link_update function.
Date: Tue, 16 Jan 2018 23:48:32 +0100
Message-ID: <20180116224832.ogn7bv4ecbdczf5h@bidouze.vm.6wind.com>
References: <20180116102906.0df665b6@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 6721C1B308
 for <dev@dpdk.org>; Tue, 16 Jan 2018 23:48:45 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id v123so11839430wmd.5
 for <dev@dpdk.org>; Tue, 16 Jan 2018 14:48:45 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20180116102906.0df665b6@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

On Tue, Jan 16, 2018 at 10:29:06AM -0800, Stephen Hemminger wrote:
> While doing link status refactoring, I noticed that the eth_dev_link_update function
> return value is unused by common code (in rte_eth_dev_link_get); but is being expected
> by failsafe driver.
> 
> The return values are not consistent across drivers, and link update function is only
> valid if device is not using LSC.  Therefore, the failsafe PMD should not be calling
> device internal functions directly and expecting a valid return value.

Yes, you are right. I will look into it.

-- 
Gaëtan Rivet
6WIND