From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v5 6/6] net/failsafe: fix removed device handling Date: Thu, 18 Jan 2018 09:44:35 +0100 Message-ID: <20180118084435.4qlmrxz6fy5nn2il@bidouze.vm.6wind.com> References: <1515587465-9304-1-git-send-email-matan@mellanox.com> <1516220357-13013-1-git-send-email-matan@mellanox.com> <1516220357-13013-7-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Ferruh Yigit , Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org To: Matan Azrad Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 35E981B2AA for ; Thu, 18 Jan 2018 09:44:49 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id 141so20940812wme.3 for ; Thu, 18 Jan 2018 00:44:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <1516220357-13013-7-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, On Wed, Jan 17, 2018 at 08:19:17PM +0000, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation which should return an error. > > In previous code this error is reported to the application contrary to > fail-safe principle that the app should not be aware of device removal. > > Add an removal check in each relevant control command error flow and > prevent an error report to application when the sub-device is removed. > > Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND