From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [PATCH] lib/librte_vhost: mov enum definition from
	PMD to lib
Date: Thu, 18 Jan 2018 21:05:42 +0800
Message-ID: <20180118130542.GE29540@yliu-mob>
References: <20180112081212.11264-1-zhiyong.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
To: Zhiyong Yang <zhiyong.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B340A2BE1
 for <dev@dpdk.org>; Thu, 18 Jan 2018 14:05:49 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180112081212.11264-1-zhiyong.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 12, 2018 at 04:12:12PM +0800, Zhiyong Yang wrote:
> The enum definition is placed in librte_vhost in order to avoid many
> duplication definitions in PMD and example code everywhere.

I moved them out from rte_vhost.h on purpose, for they are virtio-net
specific while this library is not.

So nack.

	--yliu