From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH] app/testpmd: add meter to the actions table
Date: Mon, 22 Jan 2018 08:28:47 +0100
Message-ID: <20180122072847.GA20881@sh.semihalf.local>
References: <1515678563-13424-1-git-send-email-tdu@semihalf.com>
 <3EB4FA525960D640B5BDFFD6A3D891267BAFBFA4@IRSMSX108.ger.corp.intel.com>
 <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
 Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 523757CD8
 for <dev@dpdk.org>; Mon, 22 Jan 2018 08:28:49 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id j21so7587908wmh.1
 for <dev@dpdk.org>; Sun, 21 Jan 2018 23:28:49 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jan 12, 2018 at 01:07:34PM +0000, Singh, Jasvinder wrote:
>
>
> > -----Original Message-----
> > From: Dumitrescu, Cristian
> > Sent: Thursday, January 11, 2018 6:34 PM
> > To: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions
> > table
> >
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > > Sent: Thursday, January 11, 2018 1:49 PM
> > > To: dev@dpdk.org
> > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com>
> > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions
> > > table
> > >
> > > Since METER action is supported by the testpmd application suitable
> > > entry should exist in flow actions information table.
> > >
> > > Without that testpmd will return error on adding a new flow to the
> > > list of flows attached to a given port.
> > >
> > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > > ---
> > >  app/test-pmd/config.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > > 0a84481..4ad19fb 100644
> > > --- a/app/test-pmd/config.c
> > > +++ b/app/test-pmd/config.c
> > > @@ -1038,6 +1038,7 @@ static const struct {
> > >  	MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /*
> > > +queue[] */
> > >  	MK_FLOW_ACTION(PF, 0),
> > >  	MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)),
> > > +	MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)),
> > >  };
> > >
> > >  /** Compute storage space needed by action configuration. */
> > > --
> > > 2.7.4
> >
> > Adding Jasvinder to this thread.
>
> The above change looks fine to me.
>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

Since I cannot see any objections can you pick up this one?

--
- Tomasz Duszy=C5=84ski