From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH v3 1/2] net/mlx5: fix return value of start operation Date: Mon, 22 Jan 2018 13:33:37 +0100 Message-ID: <20180122123338.19806-1-olivier.matz@6wind.com> References: <20180119162517.4451-1-olivier.matz@6wind.com> Cc: stable@dpdk.org To: dev@dpdk.org, Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh Return-path: In-Reply-To: <20180119162517.4451-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On error, mlx5_dev_start() does not return a negative value as it is supposed to do. The consequence is that the application (ex: testpmd) does not notice that the port is not started and begins the rxtx on an uninitialized port, which crashes. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") Cc: stable@dpdk.org Signed-off-by: Olivier Matz Acked-by: Nelio Laranjeiro --- v2->v3: - rebase on top of head The commit is much smaller after c7bf62255edf ("net/mlx5: fix handling link status event") For backport, prefer the v2. drivers/net/mlx5/mlx5_trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 61fa2604f..827db2e7e 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -181,7 +181,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) priv_rxq_stop(priv); priv_flow_delete_drop_queue(priv); priv_unlock(priv); - return -err; + return err; } /** -- 2.11.0