From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: mbuf vlan_tci validity unclear
Date: Mon, 22 Jan 2018 13:51:09 +0100
Message-ID: <20180122125109.6i66nim3qm2xxt3j@platinum>
References: <98CBD80474FA8B44BF855DF32C47DC35B41D73@smartserver.smartshare.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: DPDK <dev@dpdk.org>
To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id BA86A58CE
 for <dev@dpdk.org>; Mon, 22 Jan 2018 13:51:11 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B41D73@smartserver.smartshare.dk>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Morten,

On Wed, Jan 17, 2018 at 10:20:53PM +0100, Morten Brørup wrote:
> In rte_mbuf.h, the description of the PKT_RX_VLAN flag (lines 93-94) says that
> mbuf->vlan_tci contains the VLAN TCI if the flag is set; however, the
> description of the vlan_tci field (line 513) says that the
> PKT_RX_VLAN_STRIPPED flag must be set for it to be valid.
>
> Which one is it? And will someone please update the comments in rte_mbuf.h
> accordingly.

Thanks for spotting this, I will send a patch to fix it.

PKT_RX_VLAN means that mbuf->vlan_tci is valid.
And PKT_RX_VLAN_STRIPPED implies that PKT_RX_VLAN is set too.