From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v6 01/14] eal: introduce atomic exchange operation Date: Mon, 22 Jan 2018 13:48:53 -0800 Message-ID: <20180122134853.0cf85c70@xeon-e3> References: <20180116183755.24542-1-stephen@networkplumber.org> <1537329.tE083vG8Go@xps> <20180122085613.2928a3a6@xeon-e3> <4302048.2hzkQNGxWI@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Ferruh Yigit , chaozhu@linux.vnet.ibm.com, dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , Jonas Pfefferle To: Thomas Monjalon Return-path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id D932DFFA for ; Mon, 22 Jan 2018 22:48:56 +0100 (CET) Received: by mail-pf0-f194.google.com with SMTP id b25so8107228pfd.9 for ; Mon, 22 Jan 2018 13:48:56 -0800 (PST) In-Reply-To: <4302048.2hzkQNGxWI@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 22 Jan 2018 22:03:02 +0100 Thomas Monjalon wrote: > 22/01/2018 17:56, Stephen Hemminger: > > On Mon, 22 Jan 2018 00:50:55 +0100 > > Thomas Monjalon wrote: > > > > > 21/01/2018 20:25, Ferruh Yigit: > > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > > > From: Stephen Hemminger > > > > > > > > > > To handle atomic update of link status (64 bit), every driver > > > > > was doing its own version using cmpset. > > > > > Atomic exchange is a useful primitive in its own right; > > > > > therefore make it a EAL routine. > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > Reviewed-by: Ferruh Yigit > > > > Series applied to dpdk-next-net/master, thanks. > > > > > > I need to drop this series when pulling in master, > > > because PPC is not supported. > > > > > > Chao, please could you help on this feature? > > > Thanks > > > > The generic code should work for PPC. > > No, the generic code is inside #ifdef RTE_FORCE_INTRINSICS. > PPC does not define RTE_FORCE_INTRINSICS, > and ARM could disable it I guess. I will add a non intrinsic generic version using cmpset.