From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jasvinder Singh Subject: [PATCH] app/testpmd: fix dereference null return valiue Date: Mon, 22 Jan 2018 15:45:53 +0000 Message-ID: <20180122154553.108360-1-jasvinder.singh@intel.com> Cc: jingjing.wu@intel.com, john.mcnamara@intel.com To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B5E37325F for ; Mon, 22 Jan 2018 16:33:07 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Calloc() function might returns NULL due to insufficient space. Therefore, check for handling memory allocation failure is added. Coverity issue: 257030 Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Signed-off-by: Jasvinder Singh --- app/test-pmd/tm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/tm.c b/app/test-pmd/tm.c index b76335c..7231552 100644 --- a/app/test-pmd/tm.c +++ b/app/test-pmd/tm.c @@ -575,6 +575,10 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h, tc_parent_node_id = h->pipe_node_id[i][j]; tnp.shared_shaper_id = (uint32_t *)calloc(1, sizeof(uint32_t)); + if (tnp.shared_shaper_id == NULL) { + printf("Shared shaper mem alloc err\n"); + return -1; + } tnp.shared_shaper_id[0] = k; pos = j + (i * PIPE_NODES_PER_SUBPORT); h->tc_node_id[pos][k] = -- 2.9.3