From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build
 using C11 mode and pedantic
Date: Wed, 24 Jan 2018 10:27:31 -0800
Message-ID: <20180124102731.219f90cc@xeon-e3>
References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com>
 <1516803133-17529-1-git-send-email-ophirmu@mellanox.com>
 <20180124073915.753a4764@xeon-e3> <2260225.RPhyHJgTVH@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Matan Azrad <matan@mellanox.com>, stable@dpdk.org, Ophir Munk
 <ophirmu@mellanox.com>, dev@dpdk.org, Olga Shern <olgas@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 92024199AC
 for <dev@dpdk.org>; Wed, 24 Jan 2018 19:27:34 +0100 (CET)
Received: by mail-pf0-f196.google.com with SMTP id e76so3757378pfk.1
 for <dev@dpdk.org>; Wed, 24 Jan 2018 10:27:34 -0800 (PST)
In-Reply-To: <2260225.RPhyHJgTVH@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 24 Jan 2018 19:08:02 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 24/01/2018 16:39, Stephen Hemminger:
> > On Wed, 24 Jan 2018 14:12:13 +0000
> > Ophir Munk <ophirmu@mellanox.com> wrote:  
> > > --- a/drivers/net/vdev_netvsc/Makefile
> > > +++ b/drivers/net/vdev_netvsc/Makefile
> > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map
> > >  # Additional compilation flags.
> > >  CFLAGS += -O3
> > >  CFLAGS += -g
> > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra
> > > +CFLAGS += -Wall -Wextra
> > >  CFLAGS += -D_XOPEN_SOURCE=600
> > >  CFLAGS += -D_BSD_SOURCE
> > >  CFLAGS += -D_DEFAULT_SOURCE  
> > 
> > Why did this driver not use $(WERROR) like rest of DPDK drivers.  
> 
> It can be a separate patch.
> Matan?

I meant that you should use:

CFLAGS += $(WERROR_FLAGS)

instead of

CFLAGS += -Wall -Wextra

in this patch.

Also, do you really  need all the other CFLAGS? Why?

This driver has no reason to be a special case different from what is done
in virtio, vmxnet3, ixgbe, e1000, ...