From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [PATCH] net/enic: set L4 checksum flags for IPv6
	packets
Date: Thu, 25 Jan 2018 02:30:30 +0900
Message-ID: <20180124173029.GA476@HYONKIM-FTCPE.cisco.com>
References: <20180123010529.17748-1-johndale@cisco.com>
 <c277842e-2be3-601a-7171-6afea33a60f6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: John Daley <johndale@cisco.com>, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79])
 by dpdk.org (Postfix) with ESMTP id 39A761B16D
 for <dev@dpdk.org>; Wed, 24 Jan 2018 18:30:32 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <c277842e-2be3-601a-7171-6afea33a60f6@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jan 24, 2018 at 05:18:37PM +0000, Ferruh Yigit wrote:
> On 1/23/2018 1:05 AM, John Daley wrote:
> > From: Hyong Youb Kim <hyonkim@cisco.com>
> > 
> > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only
> > for IPv4.  The hardware actually validates the TCP/UDP checksum of
> > IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly.
[...]
> >  	/* checksum flags */
> > -	if (mbuf->packet_type & RTE_PTYPE_L3_IPV4) {
> > +	if (mbuf->packet_type & (RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L3_IPV6)) {
> >  		if (!enic_cq_rx_desc_csum_not_calc(cqrd)) {
> >  			uint32_t l4_flags;
> >  			l4_flags = mbuf->packet_type & RTE_PTYPE_L4_MASK;
> >  
> >  			if (enic_cq_rx_desc_ipv4_csum_ok(cqrd))
> >  				pkt_flags |= PKT_RX_IP_CKSUM_GOOD;
> > -			else
> > +			else if (mbuf->packet_type & RTE_PTYPE_L3_IPV4)
> 
> This looks like conflicting with commit log.
> Is pkt_flags intentionally not set for this case?
> If so can you update commit log to say only PKT_RX_IP_CKSUM_GOOD set for ipv6?
> 
> >  				pkt_flags |= PKT_RX_IP_CKSUM_BAD;

Yes, it is intentional. IPv6 has no IP header checksum, and
PKT_RX_IP_CKSUM_{GOOD,BAD} does not apply. So, the code does not set
PKT_RX_IP_CKSUM for IPv6. As the commit log says, for IPv6, we are
only setting L4 checksum flags.

-Hyong