From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] app/testpmd: do not enable Rx offloads by
 default
Date: Thu, 25 Jan 2018 08:01:41 -0800
Message-ID: <20180125080141.0dd6ac91@xeon-e3>
References: <1516695081-178919-1-git-send-email-motih@mellanox.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B715D7A@shsmsx102.ccr.corp.intel.com>
 <60691740.PPs9Gye6m2@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Moti Haimovsky
 <motih@mellanox.com>, dev@dpdk.org, shahafs@mellanox.com,
 ferruh.yigit@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51])
 by dpdk.org (Postfix) with ESMTP id 492DD3250
 for <dev@dpdk.org>; Thu, 25 Jan 2018 17:01:46 +0100 (CET)
Received: by mail-pg0-f51.google.com with SMTP id m136so5310587pga.12
 for <dev@dpdk.org>; Thu, 25 Jan 2018 08:01:46 -0800 (PST)
In-Reply-To: <60691740.PPs9Gye6m2@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 25 Jan 2018 10:04:11 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 25/01/2018 02:11, Lu, Wenzhuo:
> > > --- a/app/test-pmd/testpmd.c
> > > +++ b/app/test-pmd/testpmd.c
> > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = {
> > >   */
> > >  struct rte_eth_rxmode rx_mode = {
> > >  	.max_rx_pkt_len = ETHER_MAX_LEN, /**< Default maximum frame
> > > length. */
> > > -	.offloads = (DEV_RX_OFFLOAD_VLAN_FILTER |
> > > -		     DEV_RX_OFFLOAD_VLAN_STRIP |
> > > -		     DEV_RX_OFFLOAD_CRC_STRIP),
> > > +	.offloads = 0,  
> > 
> > Change the default behavior may trigger other problems. I think TX offload could be a good reference. Get the capability and check what's supported first, then ignore the not supported functions with printing a warning but not block anything...  
> 
> I agree that we should check the capabilities before requesting an offload.
> But I disagree on another point: we should not enable an offload if the
> user did not request it explicitly. It makes things unclear.
> This is a testing tool, it should be close to the ethdev API behavior.
> 
> Why these offload flags are silently enabled?

Also all virtual devices ignore CRC strip.