From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH] net/octeontx: disable PMD for old compilers
Date: Fri, 26 Jan 2018 10:55:22 +0530
Message-ID: <20180126052521.bkwtrkizp3rhlda2@Pavan-LT>
References: <20180123162240.26831-1-pbhagavatula@caviumnetworks.com>
 <11910e83-35cc-deb0-fff4-e01bde0a2240@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0075.outbound.protection.outlook.com [104.47.40.75])
 by dpdk.org (Postfix) with ESMTP id E99FE1B319
 for <dev@dpdk.org>; Fri, 26 Jan 2018 06:27:35 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <11910e83-35cc-deb0-fff4-e01bde0a2240@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 25, 2018 at 01:58:32PM +0000, Ferruh Yigit wrote:
> On 1/23/2018 4:22 PM, Pavan Nikhilesh wrote:
> > Disable for clang < 4.0 as it doesn't support the following
> > arm machine directives:
> >
> > .cpu
> >
> > This also disables event octeontx as it depends on net octeontx.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> <...>
>
> > @@ -20,3 +20,8 @@ CLANG_MINOR_VERSION := $(shell echo $(CLANG_VERSION) | cut -f2 -d.)
> >  ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 35 && echo 1), 1)
> >  	CC_SUPPORTS_Z := false
> >  endif
> > +
> > +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 40 && echo 1), 1)
> > +	CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> > +	CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> > +endif
>
> I remember we did this before but this is ugly.
>
> Can it be done in a generic way that compiler dependencies defined in the PMD
> Makefile and during config PMD may be disable based on dependency and
> environment. If there is no dependency PMD will not do anything special, does it
> make sense?

Makes sense, Will disable compiler dependent code in PMD makefile.

Thanks,
Pavan.