From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx4: fix no broadcasts reception in promisc Date: Fri, 26 Jan 2018 18:03:07 +0100 Message-ID: <20180126170307.GZ4256@6wind.com> References: <1515323086-100332-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Moti Haimovsky Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 46D141B1CA for ; Fri, 26 Jan 2018 18:03:20 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id 141so22403973wme.3 for ; Fri, 26 Jan 2018 09:03:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <1515323086-100332-1-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Moti, On Sun, Jan 07, 2018 at 01:04:46PM +0200, Moti Haimovsky wrote: > This patch fixes the issue of mlx4 not receiving broadcast packets > when configured to work promiscuous mode. Also in allmulticast mode, right? Both IBV_FLOW_ATTR_MC_DEFAULT and IBV_FLOW_ATTR_ALL_DEFAULT priorities are too low and may end up in this situation. You could add it usually occurs on VFs. > Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support") > Cc: stable@dpdk.org > > Signed-off-by: Moti Haimovsky If you confirm this problem covers allmulticast mode, please update the commit log. Otherwise, patch looks good, thanks. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND