From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <mleitner@redhat.com>
Subject: Re: [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency
	plug-in
Date: Tue, 30 Jan 2018 15:54:59 -0200
Message-ID: <20180130175459.GP3494@localhost.localdomain>
References: <20180129170310.14142-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-3-adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 7938E1B6D6
 for <dev@dpdk.org>; Tue, 30 Jan 2018 18:55:01 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180130144512.21872-3-adrien.mazarguil@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 30, 2018 at 04:34:54PM +0100, Adrien Mazarguil wrote:
...
> +	handle = dlopen(MLX4_GLUE, RTLD_LAZY);
> +	if (!handle) {
> +		rte_errno = EINVAL;
> +		dlmsg = dlerror();
> +		if (dlmsg)
> +			ERROR("cannot load glue library: %s", dlmsg);
> +		goto glue_error;
> +	}
> +	sym = dlsym(handle, "mlx4_glue");
> +	if (!sym || !*sym) {
> +		rte_errno = EINVAL;
> +		dlmsg = dlerror();
> +		if (dlmsg)
> +			ERROR("cannot resolve glue symbol: %s", dlmsg);
> +		goto glue_error;
> +	}
> +	mlx4_glue = *sym;
> +	return 0;
> +glue_error:
> +	if (handle)
> +		dlclose(handle);
> +	ERROR("cannot initialize PMD due to missing run-time"
> +	      " dependency on rdma-core libraries (libibverbs,"
> +	      " libmlx4)");

Patches are mostly LGTM. The only concern left is if ERROR is the
appropriate log level here. I know it's a fatal error for Mellanox
cards, but Considering DPDK will load all drivers for probing the hw,
these messages will show up even when using other cards. So what about
switching to WARNING instead? Should be less confusing to the users
then.

  Marcelo