From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency
	plug-in
Date: Tue, 30 Jan 2018 19:32:56 +0100
Message-ID: <20180130183256.GR4256@6wind.com>
References: <20180129170310.14142-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-3-adrien.mazarguil@6wind.com>
 <20180130175459.GP3494@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
To: Marcelo Ricardo Leitner <mleitner@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com
 [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 12CB81B6B0
 for <dev@dpdk.org>; Tue, 30 Jan 2018 19:33:10 +0100 (CET)
Received: by mail-wr0-f177.google.com with SMTP id v31so12252087wrc.11
 for <dev@dpdk.org>; Tue, 30 Jan 2018 10:33:10 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20180130175459.GP3494@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 30, 2018 at 03:54:59PM -0200, Marcelo Ricardo Leitner wrote:
> On Tue, Jan 30, 2018 at 04:34:54PM +0100, Adrien Mazarguil wrote:
> ...
> > +	handle = dlopen(MLX4_GLUE, RTLD_LAZY);
> > +	if (!handle) {
> > +		rte_errno = EINVAL;
> > +		dlmsg = dlerror();
> > +		if (dlmsg)
> > +			ERROR("cannot load glue library: %s", dlmsg);
> > +		goto glue_error;
> > +	}
> > +	sym = dlsym(handle, "mlx4_glue");
> > +	if (!sym || !*sym) {
> > +		rte_errno = EINVAL;
> > +		dlmsg = dlerror();
> > +		if (dlmsg)
> > +			ERROR("cannot resolve glue symbol: %s", dlmsg);
> > +		goto glue_error;
> > +	}
> > +	mlx4_glue = *sym;
> > +	return 0;
> > +glue_error:
> > +	if (handle)
> > +		dlclose(handle);
> > +	ERROR("cannot initialize PMD due to missing run-time"
> > +	      " dependency on rdma-core libraries (libibverbs,"
> > +	      " libmlx4)");
> 
> Patches are mostly LGTM. The only concern left is if ERROR is the
> appropriate log level here. I know it's a fatal error for Mellanox
> cards, but Considering DPDK will load all drivers for probing the hw,
> these messages will show up even when using other cards. So what about
> switching to WARNING instead? Should be less confusing to the users
> then.

Right, this is a leftover from the orginal patch that bundled mlx4_glue.so
with the PMD. An error message should only be printed when dlsym() fails,
not dlopen().

Depending on whether this series gets applied in the meantime, I'll either
send a v5 update or a separate fix tomorrow.

-- 
Adrien Mazarguil
6WIND