From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yanglong Wu Subject: [PATCH] app/testpmd:vlan filter fail Date: Thu, 1 Feb 2018 09:26:53 +0800 Message-ID: <20180201012653.173890-1-yanglong.wu@intel.com> Cc: shahafs@mellanox.com, wenzhuo.lu@intel.com, Yanglong Wu To: dev@dpdk.org Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8BCBD1B88B for ; Thu, 1 Feb 2018 02:29:09 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" And-operartion with a constant will always lead to fail for vlan filter. fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index f285ba278..d468bb4a1 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -2288,7 +2288,7 @@ rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); dev = &rte_eth_devices[port_id]; - if (!(dev->data->dev_conf.rxmode.offloads & + if (!(dev->data->dev_conf.rxmode.offloads || DEV_RX_OFFLOAD_VLAN_FILTER)) { RTE_PMD_DEBUG_TRACE("port %d: vlan-filtering disabled\n", port_id); return -ENOSYS; -- 2.11.0