From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gaetan Rivet Subject: [PATCH v1] net/failsafe: fix strerror call in sub-eal Date: Thu, 1 Feb 2018 11:18:01 +0100 Message-ID: <20180201101801.10295-1-gaetan.rivet@6wind.com> Cc: Matan Azrad , Gaetan Rivet To: dev@dpdk.org Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 91A8A2D13 for ; Thu, 1 Feb 2018 11:18:27 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r71so4765335wmd.1 for ; Thu, 01 Feb 2018 02:18:27 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ownership API returns a negative value, strerror expects a valid errno value, thus positive. CID 260401: Error handling issues (NEGATIVE_RETURNS) "ret" is passed to a parameter that cannot be negative. Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_eal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index 8946bf6fe..c3d673125 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -79,9 +79,9 @@ fs_bus_init(struct rte_eth_dev *dev) " %d named %s", i, da->name); } ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner); - if (ret) { + if (ret < 0) { INFO("sub_device %d owner set failed (%s)," - " will try again later", i, strerror(ret)); + " will try again later", i, strerror(-ret)); continue; } else if (strncmp(rte_eth_devices[pid].device->name, da->name, strlen(da->name)) != 0) { -- 2.11.0