From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link() Date: Thu, 1 Feb 2018 17:39:07 -0500 Message-ID: <20180201223907.31240-1-3chas3@gmail.com> Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, "Charles (Chas) Williams" To: dev@dpdk.org Return-path: Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by dpdk.org (Postfix) with ESMTP id 28D701BE0 for ; Thu, 1 Feb 2018 23:39:22 +0100 (CET) Received: by mail-qt0-f195.google.com with SMTP id c2so28577838qtn.9 for ; Thu, 01 Feb 2018 14:39:22 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") Signed-off-by: Chas Williams --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 37eb668..f6fd1c9 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3861,7 +3861,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed, /* for SFP+ modules and DA cables on 82599 it can take up to 500usecs * before the link status is correct */ - if (mac->type == ixgbe_mac_82599_vf) { + if (mac->type == ixgbe_mac_82599_vf && wait_to_complete) { int i; for (i = 0; i < 5; i++) { -- 2.9.5