From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yanglong Wu Subject: [PATCH] app/testpmd:vlan filter fail Date: Fri, 2 Feb 2018 13:09:50 +0800 Message-ID: <20180202050950.64400-1-yanglong.wu@intel.com> Cc: shahafs@mellanox.com, wenzhuo.lu@intel.com, Yanglong Wu To: dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1AECB2B8B for ; Fri, 2 Feb 2018 06:12:02 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and port_conf.rxmode.offloads is assigned as 0 again if hw_vlan_filter = 1. So it will always lead to fail for vlan filter setting Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5dc8ccac5..0751e573c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2328,7 +2328,7 @@ init_port_dcb_config(portid_t pid, retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) return retval; - port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; + port_conf.rxmode.hw_vlan_filter = 1; /** * Write the configuration into the device. -- 2.11.0