From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] event/rx_adapter: fix ignore return of event start Date: Fri, 2 Feb 2018 17:42:37 +0530 Message-ID: <20180202121234.GA12755@jerin> References: <1517352989-11720-1-git-send-email-vipin.varghese@intel.com> <1F668163772FA946975B9466A9DFF729E82E217A@ORSMSX110.amr.corp.intel.com> <20180131065407.GC24795@jerin> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D193E87@BGSMSX101.gar.corp.intel.com> <1F668163772FA946975B9466A9DFF729E82E351A@ORSMSX110.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Varghese, Vipin" , "dev@dpdk.org" , "Jacob, Jerin" , "Van Haaren, Harry" , Hemant Agrawal , "Jain, Deepak K" To: "Rao, Nikhil" Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0047.outbound.protection.outlook.com [104.47.42.47]) by dpdk.org (Postfix) with ESMTP id CA3491E34 for ; Fri, 2 Feb 2018 13:13:01 +0100 (CET) Content-Disposition: inline In-Reply-To: <1F668163772FA946975B9466A9DFF729E82E351A@ORSMSX110.amr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Fri, 2 Feb 2018 10:04:20 +0000 > From: "Rao, Nikhil" > To: "Varghese, Vipin" , Jerin Jacob > > CC: "dev@dpdk.org" , "Jacob, Jerin" > , "Van Haaren, Harry" > , Hemant Agrawal , > "Jain, Deepak K" > Subject: RE: [PATCH] event/rx_adapter: fix ignore return of event start > > > > -----Original Message----- > > From: Varghese, Vipin > > Sent: Friday, February 2, 2018 1:39 PM > > To: Jerin Jacob ; Rao, Nikhil > > > > Cc: dev@dpdk.org; Jacob, Jerin ; Van > > Haaren, Harry ; Hemant Agrawal > > ; Jain, Deepak K > > Subject: RE: [PATCH] event/rx_adapter: fix ignore return of event start > > > > > > > > > -----Original Message----- > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > Sent: Wednesday, January 31, 2018 6:54 AM > > > To: Rao, Nikhil > > > Cc: Varghese, Vipin ; dev@dpdk.org; Jacob, > > > Jerin ; Van Haaren, Harry > > > ; Hemant Agrawal > > ; > > > Jain, Deepak K > > > Subject: Re: [PATCH] event/rx_adapter: fix ignore return of event > > > start > > > > > > -----Original Message----- > > > > > > > > > > > > Adding eventdev PMD folks for their suggestions on how to handle the > > > > return > > > value from rte_event_dev_start() below. > > > > > > > > > -----Original Message----- > > > > > From: Varghese, Vipin > > > > > Sent: Wednesday, January 31, 2018 4:26 AM > > > > > To: dev@dpdk.org; Rao, Nikhil > > > > > Cc: Jain, Deepak K ; Varghese, Vipin > > > > > > > > > > Subject: [PATCH] event/rx_adapter: fix ignore return of event > > > > > start > > > > > > > > > > Capture the return value for rte_event_dev_start. Return the > > > > > result back to user. > > > > > > > > > > Coverity issue: 257000 > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter > > > > > implementation") > > > > > Cc: nikhil.rao@intel.com > > > > > > > > > > Signed-off-by: Vipin Varghese > > > > > --- > > > > > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > > > > > b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > > > > > index 90106e6..a818bef 100644 > > > > > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > > > > > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > > > > > @@ -603,7 +603,7 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b) > > > > > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", > > > > > dev_id); > > > > > if (started) > > > > > - rte_event_dev_start(dev_id); > > > > > + ret = rte_event_dev_start(dev_id); > > > > > > > > Currently the a non-zero return value at this point signifies an > > > > error returned > > > from rte_event_dev_configure(), so I suggest that the return value is > > > typecasted to void. > > > > > > If I understand it correctly, Any one of the failure(configure() or > > > start()) should result in bad state. Right? > > > i.e If some reason PMD is not able to start() even after failure > > > configuration() would result in bad state. > > > If so, one option could be combine the error like ret |= operation or > > > create a new logical error in Rx adapter which denotes this new error. > > > > > > > So do we agree to ACK these changes to get the code fix to the mainline? > > Sorry, if my original email wasn't clear, if rte_event_dev_configure() returns an error and rte_eventdev_start() returns success that would be a problem, i.e., the fix is incorrect. > > Of the 2 options suggested by Jerin - Since ret is not a bitmask ret |= wouldn't work, if I understand the option correctly . A new error would work. > > How about EIO ? and we also update the documentation to indicate that the event device would be in a stopped state if the return code is EIO. +1 for new error. You may consider EBUSY or EINPROGRESS also.No strong opinion for the name.