From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Date: Fri, 2 Feb 2018 14:40:07 +0100 Message-ID: <20180202134007.qvip4jkiv2gksxoj@platinum> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: thomas@monjalon.net, pbhagavatula@caviumnetworks.com, nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org To: Hemant Agrawal Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 3F2D628F3 for ; Fri, 2 Feb 2018 14:40:13 +0100 (CET) Content-Disposition: inline In-Reply-To: <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote: > From: Nipun Gupta > > The existing rte_eal_mbuf_default mempool ops can return the compile time > default ops name if the user has not provided command line inputs for > mempool ops name. It will break the logic of best mempool ops as it will > never return platform hw mempool ops. > > This patch introduces a new API to just return the user mempool ops only. > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name") > > Signed-off-by: Nipun Gupta This option is fine for me. I think we may also consider deprecating rte_eal_mbuf_default_mempool_ops(), as it is done in option 2. Acked-by: Olivier Matz