From mboxrd@z Thu Jan 1 00:00:00 1970 From: David C Harton Subject: [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs Date: Sat, 3 Feb 2018 09:55:23 -0500 Message-ID: <20180203145523.28013-1-dharton@cisco.com> Cc: dev@dpdk.org, David C Harton , olivier.matz@6wind.com To: yliu@fridaylinux.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com Return-path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 215AD25B3 for ; Sat, 3 Feb 2018 15:55:27 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" virtio_dev_free_mbufs was recently modified to free the virtqueues but failed to check whether the array was allocated. Added a check to ensure vqs was non-null. Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing") Cc: olivier.matz@6wind.com Signed-off-by: David C Harton --- drivers/net/virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 2082d6a..884f74a 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1975,6 +1975,9 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev) struct rte_mbuf *buf; int queue_type; + if (hw->vqs == NULL) + return; + for (i = 0; i < nr_vq; i++) { vq = hw->vqs[i]; if (!vq) -- 2.10.3.dirty