From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 3/4] net/mlx: version rdma-core glue
 libraries
Date: Mon, 5 Feb 2018 12:24:02 +0100
Message-ID: <20180205112402.GE4256@6wind.com>
References: <20180202144736.8239-1-adrien.mazarguil@6wind.com>
 <20180202164050.13017-1-adrien.mazarguil@6wind.com>
 <20180202164050.13017-4-adrien.mazarguil@6wind.com>
 <6047554.pbob4v6vxF@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Marcelo Ricardo Leitner <mleitner@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 9A6B51B2B8
 for <dev@dpdk.org>; Mon,  5 Feb 2018 12:24:16 +0100 (CET)
Received: by mail-wm0-f47.google.com with SMTP id b21so25153630wme.4
 for <dev@dpdk.org>; Mon, 05 Feb 2018 03:24:16 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <6047554.pbob4v6vxF@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote:
> 02/02/2018 17:46, Adrien Mazarguil:
> > --- a/drivers/net/mlx4/Makefile
> > +++ b/drivers/net/mlx4/Makefile
> > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk
> >  
> >  # Library name.
> >  LIB = librte_pmd_mlx4.a
> > -LIB_GLUE = librte_pmd_mlx4_glue.so
> > +LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION)
> > +LIB_GLUE_BASE = librte_pmd_mlx4_glue.so
> > +LIB_GLUE_VERSION = 18.02.1
> 
> You should use the version number of the release, i.e. 18.02.0
> Ideally, you should retrieve it from rte_version.h.

Keep in mind this only needs to be updated when the glue API gets modified,
and this "18.02.1" string may remain unmodified for subsequent DPDK
releases, probably as long as the PMD doesn't use any new rdma-core calls.

We've already backported this patch to 17.02 and 17.11, both requiring
different sets of Verbs calls and thus a different version, hence the added
"18.02" as a starting point. The last digit may have to be modified possibly
several times between official DPDK releases while work is being done on the
PMD (i.e. per commit).

In short it's not meant to follow DPDK's public versioning scheme. If you
really think it should, doing so will make things more complex in the
Makefile, which will have to parse rte_version.h. What's your opinion?

-- 
Adrien Mazarguil
6WIND