From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] net/octeontx: register fpa as platform HW
 mempool
Date: Mon, 5 Feb 2018 11:44:29 +0000
Message-ID: <20180205114428.GA19776@bricha3-MOBL3.ger.corp.intel.com>
References: <20180122154507.14617-1-pbhagavatula@caviumnetworks.com>
 <20180204153309.17312-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
 ferruh.yigit@intel.com, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EB7A71B33B
 for <dev@dpdk.org>; Mon,  5 Feb 2018 12:44:33 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180204153309.17312-1-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Feb 04, 2018 at 09:03:09PM +0530, Pavan Nikhilesh wrote:
> Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is
> used.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> 
>  v2 Changes:
>  - fixed compilation issues caused by using experimental API in both meson and
>  make.
> 
>  drivers/net/octeontx/Makefile          | 2 ++
>  drivers/net/octeontx/meson.build       | 2 ++
>  drivers/net/octeontx/octeontx_ethdev.c | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/drivers/net/octeontx/Makefile b/drivers/net/octeontx/Makefile
> index b47bf7a40..3e4a10662 100644
> --- a/drivers/net/octeontx/Makefile
> +++ b/drivers/net/octeontx/Makefile
> @@ -43,6 +43,8 @@ else
>  CFLAGS_octeontx_rxtx.o += -O3 -Ofast
>  endif
> 
> +CFLAGS_octeontx_ethdev.o += -DALLOW_EXPERIMENTAL_API
> +
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>  LDLIBS += -lrte_mempool_octeontx
> diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/meson.build
> index ef789eaa9..135e63e2f 100644
> --- a/drivers/net/octeontx/meson.build
> +++ b/drivers/net/octeontx/meson.build
> @@ -8,6 +8,8 @@ sources = files('octeontx_rxtx.c',
>  		'octeontx_ethdev.c'
>  		)
> 
> +cflags += '-DALLOW_EXPERIMENTAL_API'
> +

Rather than having each driver modify cflags, I've set up the variable
"allow_experimental_apis" in the top-level meson.build file. So just put

allow_experimental_apis = true

in your driver file.

/Bruce