From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v3 2/2] doc: update mlx5 required OFED version
Date: Mon, 5 Feb 2018 16:31:42 +0100
Message-ID: <20180205153142.GM4256@6wind.com>
References: <222597018bee62a6ff5898e15bf3692aa1ed09ab.1517727898.git.shahafs@mellanox.com>
 <609816b74c5db77de84e53ed1d1b1d26070b9072.1517833737.git.shahafs@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: nelio.laranjeiro@6wind.com, yskoh@mellanox.com, john.mcnamara@intel.com,
 dev@dpdk.org, olgas@mellanox.com
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
 by dpdk.org (Postfix) with ESMTP id 754F21B41A
 for <dev@dpdk.org>; Mon,  5 Feb 2018 16:31:55 +0100 (CET)
Received: by mail-wm0-f68.google.com with SMTP id b21so26686159wme.4
 for <dev@dpdk.org>; Mon, 05 Feb 2018 07:31:55 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <609816b74c5db77de84e53ed1d1b1d26070b9072.1517833737.git.shahafs@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Feb 05, 2018 at 02:31:12PM +0200, Shahaf Shuler wrote:
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

With one minor nit, title only mentions mlx5 while mlx4 is also affected:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> ---
> 
> On v3:
>  - Highlighted flow counters are supported only in MLNX_OFED. 
> 
> On v2:
>  - Updated the OFED version for mlx4 guide as well.
> ---
>  doc/guides/nics/mlx4.rst | 2 +-
>  doc/guides/nics/mlx5.rst | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
> index 88161781c..13cc6ec8a 100644
> --- a/doc/guides/nics/mlx4.rst
> +++ b/doc/guides/nics/mlx4.rst
> @@ -219,7 +219,7 @@ Current RDMA core package and Linux kernel (recommended)
>  Mellanox OFED as a fallback
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> -- `Mellanox OFED`_ version: **4.2**.
> +- `Mellanox OFED`_ version: **4.2, 4.3**.
>  - firmware version: **2.42.5000** and above.
>  
>  .. _`Mellanox OFED`: http://www.mellanox.com/page/products_dyn?product_family=26&mtag=linux_sw_drivers
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index a9e4bf51a..d54ff760a 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -131,7 +131,7 @@ Limitations
>  - A multi segment packet must have less than 6 segments in case the Tx burst function
>    is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have
>    less than 50 segments.
> -- Count action for RTE flow is only supported in Mellanox OFED 4.2.
> +- Count action for RTE flow is **only supported in Mellanox OFED**.
>  - Flows with a VXLAN Network Identifier equal (or ends to be equal)
>    to 0 are not supported.
>  - VXLAN TSO and checksum offloads are not supported on VM.
> @@ -392,7 +392,7 @@ RMDA Core with Linux Kernel
>  Mellanox OFED
>  ^^^^^^^^^^^^^
>  
> -- Mellanox OFED version: **4.2**.
> +- Mellanox OFED version: **4.2, 4.3**.
>  - firmware version:
>  
>    - ConnectX-4: **12.21.1000** and above.
> -- 
> 2.12.0
> 

-- 
Adrien Mazarguil
6WIND