From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] net/dpaa2: remove unused global variable
Date: Sat, 10 Feb 2018 18:14:25 +0530
Message-ID: <20180210124424.GA9762@jerin>
References: <20180210115736.7107-1-jerin.jacob@caviumnetworks.com>
 <AM2PR04MB07532A9ECDFD1EEF2DEA76C389F10@AM2PR04MB0753.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0067.outbound.protection.outlook.com [104.47.33.67])
 by dpdk.org (Postfix) with ESMTP id EC1F51B638
 for <dev@dpdk.org>; Sat, 10 Feb 2018 13:44:44 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <AM2PR04MB07532A9ECDFD1EEF2DEA76C389F10@AM2PR04MB0753.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Sat, 10 Feb 2018 12:02:24 +0000
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> Subject: RE: [dpdk-dev]  [PATCH] net/dpaa2: remove unused global variable
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Saturday, February 10, 2018 5:28 PM
> > To: dev@dpdk.org
> > Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>
> > Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable
> > Importance: High
> > 
> > Due to the missing __packed definition, compiler treating it as as global variable.
> 
> > 
> > #grep "Allocating common symbols" -A 100 build/app/testacl.map
> > __packed   0x8  /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o)
> 
> [Hemant] Which compiler, you mean you faced issue with testacl app? 

arm64 gcc. Not specific to testacl. We were getting minor performance
regression (<1%) with l3fwd after the following change set.
http://dpdk.org/dev/patchwork/patch/34709/

I don't think, the above change set directly has anything due to issue.
I was chasing that issue and found that global variables has something
due to with change.Most probably because it has indirect effect of changing
the complete address generated in the binary and thus showing up some cached
alignment related artifacts.

> 
> > 
> > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing")
> > 
> > Cc: hemant.agrawal@nxp.com
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> <snip>....