From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] doc: announce control mbuf removal
Date: Mon, 12 Feb 2018 11:05:01 +0000
Message-ID: <20180212110501.GA13612@bricha3-MOBL3.ger.corp.intel.com>
References: <20180129093027.16357-1-olivier.matz@6wind.com>
 <20180212102215.bzowbuxr7r6asliq@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>,
 Kevin Wilson <wkevils@gmail.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 682191B30B
 for <dev@dpdk.org>; Mon, 12 Feb 2018 12:05:07 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180212102215.bzowbuxr7r6asliq@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Feb 12, 2018 at 11:22:15AM +0100, Olivier Matz wrote:
> Hi,
> 
> Please, any other comments or acks for this one?
> 
> Thanks
> Olivier

I would tend to support leaving the flag in place. Other than that, I
think the functions for it can go.
> 
> 
> On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote:
> > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html
> > Link: http://dpdk.org/dev/patchwork/patch/32041/
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> >  doc/guides/rel_notes/deprecation.rst | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index d59ad5988..e98ce6a0a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -59,3 +59,16 @@ Deprecation Notices
> >    be added between the producer and consumer structures. The size of the
> >    structure and the offset of the fields will remain the same on
> >    platforms with 64B cache line, but will change on other platforms.
> > +
> > +* mbuf: The control mbuf API will be removed in v18.05. The impacted
> > +  functions and macros are:
> > +
> > +  - ``rte_ctrlmbuf_init()``
> > +  - ``rte_ctrlmbuf_alloc()``
> > +  - ``rte_ctrlmbuf_free()``
> > +  - ``rte_ctrlmbuf_data()``
> > +  - ``rte_ctrlmbuf_len()``
> > +  - ``rte_is_ctrlmbuf()``
> > +  - ``CTRL_MBUF_FLAG``
> > +
> > +  The packet mbuf API should be used as a replacement.
> > -- 
> > 2.11.0
> >