From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: adjust error log level
Date: Thu, 15 Feb 2018 10:55:19 -0800
Message-ID: <20180215105519.59319db9@xeon-e3>
References: <1518534227-104477-1-git-send-email-martinx.klozik@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
To: Martin Klozik <martinx.klozik@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com
 [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 965501B2C7
 for <dev@dpdk.org>; Thu, 15 Feb 2018 19:55:22 +0100 (CET)
Received: by mail-pl0-f65.google.com with SMTP id t4so343489plo.0
 for <dev@dpdk.org>; Thu, 15 Feb 2018 10:55:22 -0800 (PST)
In-Reply-To: <1518534227-104477-1-git-send-email-martinx.klozik@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 13 Feb 2018 15:03:47 +0000
Martin Klozik <martinx.klozik@intel.com> wrote:

> DPDK API does not propagate the reason of device allocation failure
> from rte_eth_dev_allocate() up to the DPDK application (e.g. Open
> vSwitch).
> Log level of associated log entries was changed to warning. So user
> can find additional details in log files also in production systems,
> where debug messages cannot be turned on.
> 
> Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index a6ce2a5..0590f0c 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -277,12 +277,12 @@ rte_eth_dev_allocate(const char *name)
>  
>  	port_id = rte_eth_dev_find_free_port();
>  	if (port_id == RTE_MAX_ETHPORTS) {
> -		RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports\n");
> +		RTE_LOG(ERR, EAL, "Reached maximum number of Ethernet ports\n");
>  		goto unlock;
>  	}
>  
>  	if (rte_eth_dev_allocated(name) != NULL) {
> -		RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n",
> +		RTE_LOG(ERR, EAL, "Ethernet Device with name %s already allocated!\n",
>  				name);
>  		goto unlock;
>  	}

Should be NOTICE not ERROR. Since this is a recoverable condition.