From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: release/acquire memory barriers and ring
Date: Fri, 16 Feb 2018 09:58:12 -0800
Message-ID: <20180216095812.7e634a53@xeon-e3>
References: <CAMKNYbw7=b69eCM17p8SperLRD86wtKw3iLj1FtG8gL7bUakNg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Alex Kiselev <kiselev99@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com
 [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 0BB7D1B2BA
 for <dev@dpdk.org>; Fri, 16 Feb 2018 18:58:16 +0100 (CET)
Received: by mail-pl0-f65.google.com with SMTP id g18so2065948plo.7
 for <dev@dpdk.org>; Fri, 16 Feb 2018 09:58:15 -0800 (PST)
In-Reply-To: <CAMKNYbw7=b69eCM17p8SperLRD86wtKw3iLj1FtG8gL7bUakNg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 13 Feb 2018 22:37:37 +0300
Alex Kiselev <kiselev99@gmail.com> wrote:

> Hi.
> 
> I've been wondering should I use a release/acquire memory barrier pair
> in order to be sure that the other thread will see the fully/corrected
> initialized object
> passed to it via a dpdk ring or ring itself is a kind of barrier?
> 
> Let's say I have a pseudo code:
> 
> Thread1:
> obj = alloc();
> ...
> obj initialization
> ...
> 
> ??? fence(memory_order_release); ???
> rte_ring_sp_enqueue(ring, obj)
> 
> 
> Thread2:
> ??? fence(memory_order_acquire); ???
> rte_ring_sc_dequeue(ring, obj)
> 
> Should I use fences in that code?
> 
> Thanks.
> 
> --
> Alex

Not necessary. Enqueue/dequeue has necessary ordering; it is built
on compare-exchange which has implied barrier.