From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 1/7] net/af_xdp: new PMD driver
Date: Wed, 28 Feb 2018 15:42:17 -0800
Message-ID: <20180228154217.4aff5095@xeon-e3>
References: <20180227093306.23854-1-qi.z.zhang@intel.com>
 <20180227093306.23854-2-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, magnus.karlsson@intei.com, bjorn.topel@intel.com
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50])
 by dpdk.org (Postfix) with ESMTP id D004F2A5E
 for <dev@dpdk.org>; Thu,  1 Mar 2018 00:42:20 +0100 (CET)
Received: by mail-pg0-f50.google.com with SMTP id l4so1568418pgp.11
 for <dev@dpdk.org>; Wed, 28 Feb 2018 15:42:20 -0800 (PST)
In-Reply-To: <20180227093306.23854-2-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 27 Feb 2018 17:33:00 +0800
Qi Zhang <qi.z.zhang@intel.com> wrote:

> struct pmd_internals {
> +	int sfd;
> +	int if_index;
> +	char if_name[0x100];

why not IFNAMSIZ?

> +	struct ether_addr eth_addr;
> +	struct xdp_queue rx;
> +	struct xdp_queue tx;
> +	struct xdp_umem *umem;
> +	struct rte_mempool *mb_pool;
> +
> +	unsigned long rx_pkts;
> +	unsigned long rx_bytes;
> +	unsigned long rx_dropped;
> +
> +	unsigned long tx_pkts;
> +	unsigned long err_pkts;
> +	unsigned long tx_bytes;

why not per-queue stats? per-port stats are expensive

> +	uint16_t port_id;
> +	uint16_t queue_idx;
> +	int ring_size;
> +	struct rte_ring *buf_ring;
> +};