From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 4/7] net/af_xdp: use mbuf mempool for buffer
 management
Date: Wed, 28 Feb 2018 18:08:11 -0800
Message-ID: <20180228180811.700dea88@xeon-e3>
References: <20180227093306.23854-1-qi.z.zhang@intel.com>
 <20180227093306.23854-5-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, magnus.karlsson@intei.com, bjorn.topel@intel.com
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com
 [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id 9BC1E4C7B
 for <dev@dpdk.org>; Thu,  1 Mar 2018 03:08:15 +0100 (CET)
Received: by mail-pf0-f194.google.com with SMTP id d26so1829104pfn.5
 for <dev@dpdk.org>; Wed, 28 Feb 2018 18:08:15 -0800 (PST)
In-Reply-To: <20180227093306.23854-5-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 27 Feb 2018 17:33:03 +0800
Qi Zhang <qi.z.zhang@intel.com> wrote:

> +static uint32_t
> +mbuf_to_idx(struct pmd_internals *internals, struct rte_mbuf *mbuf)
> +{
> +	return (uint32_t)(((uint64_t)mbuf->buf_addr -
> +			   (uint64_t)internals->umem->buffer) >>
> +			  internals->umem->frame_size_log2);
> +}
> +
> +static struct rte_mbuf *
> +idx_to_mbuf(struct pmd_internals *internals, uint32_t idx)
> +{
> +	return (struct rte_mbuf *)(void *)(internals->umem->buffer + (idx
> +			<< internals->umem->frame_size_log2) + 0x40);
> +}

More unnecessary casts's here.