From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] kni: fix compilation under RHEL 7.5
Date: Thu, 1 Mar 2018 16:18:15 -0800
Message-ID: <20180301161815.6c7771a6@xeon-e3>
References: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: ferruh.yigit@intel.com, dev@dpdk.org
To: Lee Roberts <lee.roberts@hpe.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com
 [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 31D805681
 for <dev@dpdk.org>; Fri,  2 Mar 2018 01:18:22 +0100 (CET)
Received: by mail-pl0-f65.google.com with SMTP id 61-v6so4636821plf.3
 for <dev@dpdk.org>; Thu, 01 Mar 2018 16:18:22 -0800 (PST)
In-Reply-To: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  1 Mar 2018 16:20:35 -0700
Lee Roberts <lee.roberts@hpe.com> wrote:

> Fix kni compilation under RHEL 7.5.
> 
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> ---
>  lib/librte_eal/linuxapp/kni/compat.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
> index 3f8c0bc..6a6968d 100644
> --- a/lib/librte_eal/linuxapp/kni/compat.h
> +++ b/lib/librte_eal/linuxapp/kni/compat.h
> @@ -101,6 +101,11 @@
>  #undef NET_NAME_UNKNOWN
>  #endif
>  
> +#if (defined(RHEL_RELEASE_CODE) && \
> +	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> +#define ndo_change_mtu ndo_change_mtu_rh74
> +#endif
> +
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
>  #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
>  #endif

Do we really want upstream DPDK trying to track every vendor kernel compatibility wart?
Should Redhat be owning this in their own DPDK package?