From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Duszynski Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases Date: Thu, 8 Mar 2018 14:27:17 +0100 Message-ID: <20180308132717.GB22443@sh> References: <1519829633-32295-1-git-send-email-tdu@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, bruce.richardson@intel.com, Tomasz Duszynski , stable@dpdk.org To: dev@dpdk.org Return-path: Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) by dpdk.org (Postfix) with ESMTP id 2C6D65F14 for ; Thu, 8 Mar 2018 14:27:19 +0100 (CET) Received: by mail-lf0-f66.google.com with SMTP id q69-v6so8276944lfi.10 for ; Thu, 08 Mar 2018 05:27:19 -0800 (PST) Content-Disposition: inline In-Reply-To: <1519829633-32295-1-git-send-email-tdu@semihalf.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch has been here for a while already. Should I respin it? On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote: > MRVL Crypto PMD supports most of the hash algorithms covered > by test suites thus specific bits should be set in pmd_masks. > > Otherwise blockcipher authonly test returns success even though no > real tests have been executed. > > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") > Cc: stable@dpdk.org > > Signed-off-by: Tomasz Duszynski > --- > test/test/test_cryptodev_hash_test_vectors.h | 66 ++++++++++++++++++----= ------ > 1 file changed, 44 insertions(+), 22 deletions(-) > > diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/tes= t_cryptodev_hash_test_vectors.h > index 93dacb7..df9202f 100644 > --- a/test/test/test_cryptodev_hash_test_vectors.h > +++ b/test/test/test_cryptodev_hash_test_vectors.h > @@ -324,13 +324,15 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > .test_descr =3D "MD5 Digest", > .test_data =3D &md5_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "MD5 Digest Verify", > .test_data =3D &md5_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-MD5 Digest", > @@ -341,7 +343,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-MD5 Digest Verify", > @@ -352,19 +355,22 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA1 Digest", > .test_data =3D &sha1_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA1 Digest Verify", > .test_data =3D &sha1_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA1 Digest", > @@ -375,7 +381,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA1 Digest Scatter Gather", > @@ -394,7 +401,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA1 Digest Verify Scatter Gather", > @@ -408,13 +416,15 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > .test_descr =3D "SHA224 Digest", > .test_data =3D &sha224_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA224 Digest Verify", > .test_data =3D &sha224_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA224 Digest", > @@ -442,13 +452,15 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > .test_descr =3D "SHA256 Digest", > .test_data =3D &sha256_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA256 Digest Verify", > .test_data =3D &sha256_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA256 Digest", > @@ -459,7 +471,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA256 Digest Verify", > @@ -470,19 +483,22 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA384 Digest", > .test_data =3D &sha384_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA384 Digest Verify", > .test_data =3D &sha384_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA384 Digest", > @@ -493,7 +509,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA384 Digest Verify", > @@ -504,19 +521,22 @@ static const struct blockcipher_test_case hash_test= _cases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA512 Digest", > .test_data =3D &sha512_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_GEN, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "SHA512 Digest Verify", > .test_data =3D &sha512_test_vector, > .op_mask =3D BLOCKCIPHER_TEST_OP_AUTH_VERIFY, > - .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL > + .pmd_mask =3D BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA512 Digest", > @@ -527,7 +547,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > { > .test_descr =3D "HMAC-SHA512 Digest Verify", > @@ -538,7 +559,8 @@ static const struct blockcipher_test_case hash_test_c= ases[] =3D { > BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC | > BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC | > - BLOCKCIPHER_TEST_TARGET_PMD_QAT > + BLOCKCIPHER_TEST_TARGET_PMD_QAT | > + BLOCKCIPHER_TEST_TARGET_PMD_MRVL > }, > }; > > -- > 2.7.4 > -- - Tomasz Duszy=C5=84ski